I have done it both ways - running in vinegar and sitting in vinegar. I was told that when storing pumps it is a good idea to take them apart. That way any water or moisture will evaporate out and not sit in the impeller area.